Go back –> ath6kl
Use a variable named “ret” to store return values or status codes. Also propagate the error code to upper levels.
Example:
int ret; ret = request_firmware(&fw_entry, filename, ar->dev); if (ret) return ret;
Name context variables either “ar” or “ar_<hifname>”. Use ath6kl_<hifname>_priv() to get access to hif specific context.
Examples:
struct ath6kl *ar = ptr; struct ath6kl_sdio *ar_sdio = ath6kl_sdio_priv(ar);
For consistency always use the main context (struct ath6kl *ar) as function parameter, don't use hif specific context.
Use goto labels err_<action> for handing error path, with <action> giving a clear idea what the label does.
Example:
ret = ath6kl_hif_power_on(ar); if (ret) return ret; ret = ath6kl_configure_target(ar); if (ret) goto err_power_off; ret = ath6kl_init_upload(ar); if (ret) goto err_cleanup_target; return 0; err_cleanup_scatter: ath6kl_cleanup_target(ar); err_power_off: ath6kl_hif_power_off(ar); return ret;
Always document what spinlock/mutex/rcu actually protects. Locks should always protect data, not code flow.
Name of symbols and functions follow style <drivername>_<filename>_<symbolname>.
Example:
int ath6kl_init_hw(struct ath6kl *ar)
For each component use function names create/destroy for allocating and freeing something, init/cleanup for initialising variables and cleaning up them afterwards and start/stop to temporarily pause something.
Example:
int ath6kl_cfg80211_create(struct ath6kl *ar) int ath6kl_cfg80211_start(struct ath6kl *ar) void ath6kl_cfg80211_stop(struct ath6kl *ar) void ath6kl_cfg80211_destory(struct ath6kl *ar)
Don't use void pointers.
Don't use typedef.
Follow Linux Coding Style.