This shows you the differences between two versions of the page.
Both sides previous revision Previous revision Next revision | Previous revision Next revision Both sides next revision | ||
en:users:drivers:ath10k:submittingpatches [2018/04/13 04:32] Kalle Valo [Guidelines] Add a link to Tested-by and Reported-by documentation |
en:users:drivers:ath10k:submittingpatches [2020/06/09 12:11] Kalle Valo State importance of cc linux-wireless |
||
---|---|---|---|
Line 10: | Line 10: | ||
Preferably use [[en/users/drivers/ath10k/sources|ath.git master branch]] as the baseline for patches. Other trees can be used as well, but then the chances of conflicts are higher. | Preferably use [[en/users/drivers/ath10k/sources|ath.git master branch]] as the baseline for patches. Other trees can be used as well, but then the chances of conflicts are higher. | ||
- | You can follow the state of ath10k patch review from patchwork: | + | It's important that linux-wireless is CCed on the patches, otherwise it won't be in patchwork and the maintainer won't see it. You can follow the state of ath10k patch review from patchwork: |
[[https://patchwork.kernel.org/project/linux-wireless/list/?state=*&q=ath10k]] | [[https://patchwork.kernel.org/project/linux-wireless/list/?state=*&q=ath10k]] | ||
Line 16: | Line 16: | ||
More info about submitting patches: | More info about submitting patches: | ||
* [[en/developers/Documentation/SubmittingPatches|linux-wireless submitting patches instructions]] | * [[en/developers/Documentation/SubmittingPatches|linux-wireless submitting patches instructions]] | ||
- | * [[en/developers/Documentation/git-guide|linux-wireless git guide]] | + | * [[en/developers/Documentation/git-guide|linux-wireless git guide]] |
+ | * [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html|Linux kernel submitting patches]] | ||
+ | * [[https://medium.com/@steveamaza/how-to-write-a-proper-git-commit-message-e028865e5791|How to write proper git commit messages]] | ||
==== Guidelines ==== | ==== Guidelines ==== | ||
Line 39: | Line 41: | ||
* QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00102-QCARMSWP-1 | * QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00102-QCARMSWP-1 | ||
* QCA9377 SDIO WLAN.TF.1.1.1-00061-QCATFSWPZ-1 | * QCA9377 SDIO WLAN.TF.1.1.1-00061-QCATFSWPZ-1 | ||
- | * SHOULD use [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes|Reported-by: and Tested-by: tags]] if others have reported the issue. | + | * SHOULD use [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes|Reported-by: and Tested-by: tags]] if others have reported the issue. |
+ | * SHOULD use [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes|Fixes: tag]] if it fixes a regression caused by known commit. | ||
* SHOULD be //mostly// checkpatch clean (though not all patchworks warnings make sense), it's RECOMMENDED to test patches with [[en/users/Drivers/ath10k/CodingStyle#checking_code|ath10k-check]] as that will disable the useless warnings. | * SHOULD be //mostly// checkpatch clean (though not all patchworks warnings make sense), it's RECOMMENDED to test patches with [[en/users/Drivers/ath10k/CodingStyle#checking_code|ath10k-check]] as that will disable the useless warnings. | ||