en:users:drivers:ath10k:submittingpatches
Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision Next revision Both sides next revision | ||
|
en:users:drivers:ath10k:submittingpatches [2018/04/13 04:21] Kalle Valo [Guidelines] Fix a typo |
en:users:drivers:ath10k:submittingpatches [2018/04/13 04:34] Kalle Valo [Guidelines] Add Fixes tag |
||
|---|---|---|---|
| Line 27: | Line 27: | ||
| * [[https://www.kernel.org/pub/software/scm/git/docs/git-send-email.html|git send-email]] SHOULD be used to submit the patch to avoid any formatting issues. | * [[https://www.kernel.org/pub/software/scm/git/docs/git-send-email.html|git send-email]] SHOULD be used to submit the patch to avoid any formatting issues. | ||
| * Patchsets SHOULD contain no more than 12 patches and include a cover letter. | * Patchsets SHOULD contain no more than 12 patches and include a cover letter. | ||
| - | * The commit log MUST answer the question "Why?": | + | * Commit log MUST answer the question "Why?": |
| * Describe the motivation behind the bug. | * Describe the motivation behind the bug. | ||
| * How does it change the functionality from user's point of view? | * How does it change the functionality from user's point of view? | ||
| Line 39: | Line 39: | ||
| * QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00102-QCARMSWP-1 | * QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00102-QCARMSWP-1 | ||
| * QCA9377 SDIO WLAN.TF.1.1.1-00061-QCATFSWPZ-1 | * QCA9377 SDIO WLAN.TF.1.1.1-00061-QCATFSWPZ-1 | ||
| - | * SHOULD use Reported-by: and Tested-by: tags if others have reported the issue. | + | * SHOULD use [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes|Reported-by: and Tested-by: tags]] if others have reported the issue. |
| + | * SHOULD use [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes|Fixes: tag]] if it fixes a regression caused by known commit. | ||
| * SHOULD be //mostly// checkpatch clean (though not all patchworks warnings make sense), it's RECOMMENDED to test patches with [[en/users/Drivers/ath10k/CodingStyle#checking_code|ath10k-check]] as that will disable the useless warnings. | * SHOULD be //mostly// checkpatch clean (though not all patchworks warnings make sense), it's RECOMMENDED to test patches with [[en/users/Drivers/ath10k/CodingStyle#checking_code|ath10k-check]] as that will disable the useless warnings. | ||
en/users/drivers/ath10k/submittingpatches.txt · Last modified: 2020/08/26 14:40 by Kalle Valo
Page Tools
