This shows you the differences between two versions of the page.
Both sides previous revision Previous revision Next revision | Previous revision Next revision Both sides next revision | ||
en:developers:documentation:submittingpatches [2021/02/12 08:22] Johannes Berg |
en:developers:documentation:submittingpatches [2021/12/22 06:39] Kalle Valo [Use RFC or RFT for patches not ready] Add examples |
||
---|---|---|---|
Line 192: | Line 192: | ||
There's also a list of [[https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred|preferred licenses]] available. | There's also a list of [[https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred|preferred licenses]] available. | ||
+ | Some guidelines to speed up new driver review: | ||
+ | |||
+ | * keep the driver small and simple, more features can be added after the driver is accepted upstream | ||
+ | * use clean understandable code | ||
+ | * use generic kernel frameworks instead of reinventing the wheel | ||
+ | * use generic user space interfaces | ||
+ | * no driver specific user interfaces or hacks | ||
+ | * no .ini style driver configuration files | ||
+ | * avoid using debugfs or nl80211 vendor interfaces | ||
===== Examples of a patches ===== | ===== Examples of a patches ===== | ||
Line 402: | Line 411: | ||
==== Use RFC or RFT for patches not ready ==== | ==== Use RFC or RFT for patches not ready ==== | ||
- | If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test). This way the maintainer can easily see that the patch should not be applied yet. This saves a lot of maintainer's time. | + | If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test) in the subject. This way the maintainer can easily see that the patch should not be applied yet and saves maintainer's time. |
+ | |||
+ | Examples: | ||
+ | |||
+ | [PATCH RFC] ath11k: enable power save mode always | ||
+ | [PATCH RFT] ath10k: sdio: always use DMA transfers | ||
==== Use Co-developed-by when multiple authors ==== | ==== Use Co-developed-by when multiple authors ==== |