en:developers:documentation:submittingpatches
Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision Next revision | Previous revision Next revision Both sides next revision | ||
|
en:developers:documentation:submittingpatches [2020/02/13 16:29] Kalle Valo Add Co-developed-by |
en:developers:documentation:submittingpatches [2020/10/08 07:34] Kalle Valo [Signed-off-by missing] clarify that DCO needs to be read and understood |
||
|---|---|---|---|
| Line 264: | Line 264: | ||
| ==== Signed-off-by missing ==== | ==== Signed-off-by missing ==== | ||
| - | Read [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin|Developer's Certificate of Origin]] and add Signed-off-by to the commit log. | + | Read [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin|Developer's Certificate of Origin]]. Do not submit patches unless you have read, understood and agreed to the certificate. |
| ==== Format issues ==== | ==== Format issues ==== | ||
| Line 358: | Line 359: | ||
| More info: http://www.idallen.com/topposting.html | More info: http://www.idallen.com/topposting.html | ||
| + | |||
| + | ==== Do not send HTML mail ==== | ||
| + | |||
| + | linux-wireless mailing list drops all mail using HTML, so don't use it. | ||
| ==== Use RFC or RFT for patches not ready ==== | ==== Use RFC or RFT for patches not ready ==== | ||
| Line 368: | Line 373: | ||
| https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by | https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by | ||
| + | |||
| + | ==== Maximum of 7-12 patches per patchset ==== | ||
| + | |||
| + | If you want your patches reviewed smoothly submit maximum of 7-12 patches per patchset. If the patches are bigger don't send more than 7 patches. But if they smaller, or trivial patches, 12 patches is ok. But anything more than 12 patches and you will get reviewers grumpy (read: it takes longer to get your patches reviewed and applied). | ||
| + | |||
| + | But you can submit multiple patchsets, just try to throttle it down to avoid bufferbloat in patchwork, for example you can send a new patchset every other day. And don't forget to document the dependencies in the cover letter ("this patchset depends on patchset B"). | ||
| ===== More references ===== | ===== More references ===== | ||
en/developers/documentation/submittingpatches.txt · Last modified: 2024/02/01 20:12 by Jeff Johnson
Page Tools
