User Tools

Site Tools


en:developers:documentation:submittingpatches

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
Next revision Both sides next revision
en:developers:documentation:submittingpatches [2019/06/23 09:14]
Thomas Nagy [Fixes line is incorrect] mention placement compared to signed-off-by
en:developers:documentation:submittingpatches [2020/04/17 08:25]
Kalle Valo Add an entry about patchset limits
Line 33: Line 33:
  
   * [[en/​users/​drivers/​ath10k/​submittingpatches|ath10k]]   * [[en/​users/​drivers/​ath10k/​submittingpatches|ath10k]]
 +  * [[en/​users/​drivers/​ath11k/​submittingpatches|ath11k]]
 ===== Checking state of patches from patchwork ===== ===== Checking state of patches from patchwork =====
  
Line 357: Line 358:
  
 More info: http://​www.idallen.com/​topposting.html More info: http://​www.idallen.com/​topposting.html
 +
 +==== Do not send HTML mail ====
 +
 +linux-wireless mailing list drops all mail using HTML, so don't use it.
  
 ==== Use RFC or RFT for patches not ready ==== ==== Use RFC or RFT for patches not ready ====
Line 362: Line 367:
 If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test). This way the maintainer can easily see that the patch should not be applied yet. This saves a lot of maintainer'​s time. If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test). This way the maintainer can easily see that the patch should not be applied yet. This saves a lot of maintainer'​s time.
  
 +==== Use Co-developed-by when multiple authors ​ ====
 +
 +When a patch has multiple authors you should use Co-developed-by tag:
 +
 +https://​www.kernel.org/​doc/​html/​latest/​process/​submitting-patches.html#​when-to-use-acked-by-cc-and-co-developed-by
 +
 +==== Maximum of 7-12 patches per patchset ​ ====
 +
 +If you want your patches reviewed smoothly submit maximum of 7-12 patches per patchset. If the patches are bigger don't send more than 7 patches. But if they smaller, or trivial patches, 12 patches is ok. But anything more than 12 patches and you will get reviewers grumpy (read: it takes longer to get your patches reviewed and applied).
 +
 +But you can submit multiple patchsets, just try to throttle it down to avoid bufferbloat in patchwork, for example you can send a new patchset every other day. And don't forget to document the dependencies in the cover letter ("this patchset depends on patchset B").
  
 ===== More references ===== ===== More references =====
en/developers/documentation/submittingpatches.txt ยท Last modified: 2024/02/01 20:12 by Jeff Johnson