Differences

This shows you the differences between two versions of the page.

--- en:developers:documentation:submittingpatches [2018/03/27 14:12]
Kalle Valo [Format of patches] Mention about git-format-patch and git-send-email
+++ en:developers:documentation:submittingpatches [2018/06/14 08:10]
Kalle Valo [More patch work references] Change title, "patch work" is easy to confuse with patchwork (the tool)
@@ Line 321: / Line 321: @@
 The commit log needs to tell why you wrote the patch. If you fixed a bug give a short summary of the bug (can be a long one as well, of course) from user's point of view, and if there's a publically available bug report include a link to that. If you are fixing a warning from a compiler or a static checker add the warning from tool. Or if it's just code cleanup or fixing a theoretical issue, and does not have practical user visible changes, mention that also.
-===== More patch work references =====
+==== Do not top post and edit your quotes ====
+Top posting makes following email threads hard to follow and also it makes use of patchwork more difficult, which gets the maintainers grumpy as you are making their work more difficult. So do not top post and instead edit your quotes properly.
+<code>A: Because it messes up the order in which people normally read text.
+Q: Why is top-posting such a bad thing?
+A: Top-posting.
+Q: What is the most annoying thing in e-mail?
+A: No.
+Q: Should I include quotations after my reply?
+</code>
+More info: http://www.idallen.com/topposting.html
+==== Use RFC or RFT for patches not ready ====
+If the patches are not yet ready to be applied by the maintainer mark them as RFC (Request For Comments) or RFC (Request For Test), this way the maintainer can easily see that the patch should not be applied yet. This saves a lot of maintainer's time.
+===== More references =====
 Here is a list of links to help you write better patches
@@ Line 329: / Line 349: @@
   * [[http://linux.yyz.us/patch-format.html|http://linux.yyz.us/patch-format.html]]
   * [[https://www.ozlabs.org/~akpm/stuff/tpp.txt|Andrew Morton's ''The perfect patch'']]
+  * [[http://lkml.kernel.org/r/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com|Make Bjorn's life easier (and grease the path of your patch)]]

Linux Wireless

User Tools

Site Tools

Differences

Page Tools