Differences

This shows you the differences between two versions of the page.

--- en:developers:documentation:submittingpatches [2021/02/12 08:22]
Johannes Berg
+++ en:developers:documentation:submittingpatches [2022/02/18 13:40]
Kalle Valo [Tree labels] mac80211 and wireless-drivers trees are not used anymore
@@ Line 23: / Line 23: @@
 CC: linux-wireless@vger.kernel.org, Other Developers</code>
-For wireless-drivers patches (except mac80211_hwsim) send patches as:
+For wireless drivers patches (except mac80211_hwsim) send patches as:
 <code>To: linux-wireless@vger.kernel.org
@@ Line 126: / Line 126: @@
 Alternatively you can specify the exact tree you are targetting by adding the name of the git tree inside PATCH brackets:
-<code>[PATCH mac80211] mac80211: fix foo
+<code>[PATCH wireless] mac80211: fix foo
-[PATCH mac80211-next] mac80211: implement very-cool-feature
+[PATCH wireless-next] mac80211: implement very-cool-feature
-[PATCH wireless-drivers] ath10k: fix foo
+[PATCH wireless] ath10k: fix foo
-[PATCH wireless-drivers-next] ath10k: implement awesome-feature
+[PATCH wireless-next] ath10k: implement awesome-feature
 </code>
@@ Line 192: / Line 192: @@
 There's also a list of [[https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred|preferred licenses]] available.
+Some guidelines to speed up new driver review:
+  * keep the driver small and simple, more features can be added after the driver is accepted upstream
+  * use clean understandable code
+  * use generic kernel frameworks instead of reinventing the wheel
+  * use generic user space interfaces
+    * no driver specific user interfaces or hacks
+    * no .ini style driver configuration files
+  * avoid using debugfs or nl80211 vendor interfaces
 ===== Examples of a patches =====
@@ Line 402: / Line 411: @@
 ==== Use RFC or RFT for patches not ready ====
-If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test). This way the maintainer can easily see that the patch should not be applied yet. This saves a lot of maintainer's time.
+If the patches are not yet ready to be applied by the maintainer, mark them as RFC (Request For Comments) or RFT (Request For Test) in the subject. This way the maintainer can easily see that the patch should not be applied yet and saves maintainer's time.
+Examples:
+  [PATCH RFC] ath11k: enable power save mode always
+  [PATCH RFT] ath10k: sdio: always use DMA transfers
 ==== Use Co-developed-by when multiple authors  ====

Linux Wireless

User Tools

Site Tools

Differences

Page Tools