This shows you the differences between two versions of the page.
Both sides previous revision Previous revision Next revision | Previous revision Next revision Both sides next revision | ||
en:developers:documentation:submittingpatches [2017/05/16 05:30] Kalle Valo [Who to address] Updated location of ath10k submitting patches page |
en:developers:documentation:submittingpatches [2017/05/26 05:41] Kalle Valo Add frequent problem "Fixes line is incorrect" |
||
---|---|---|---|
Line 243: | Line 243: | ||
Read [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin|Developer's Certificate of Origin]] and add Signed-off-by to the commit log. | Read [[https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin|Developer's Certificate of Origin]] and add Signed-off-by to the commit log. | ||
+ | |||
+ | ==== Format issues ==== | ||
+ | |||
+ | Patch is somehow whitespace damaged, for example tabs converted to spaces, extra new lines or other modifications which prevent applying the patch without manual fixing. Or the mail is in HTML format which most of the mailing lists even block silently. | ||
+ | |||
+ | The best way to avoid all formatting issues is to use [[https://www.kernel.org/pub/software/scm/git/docs/git-send-email.html|git send-email]] | ||
+ | |||
+ | ==== Fixes line is incorrect ==== | ||
+ | |||
+ | The correct format for the commit references in Fixes line is the 12 initial digits | ||
+ | of the SHA1_ID of the commit, followed by a space, followed by the | ||
+ | commit log message header line text enclosed in parentheses and | ||
+ | double quotes with no line breaks whatsoever. | ||
+ | |||
+ | Example: | ||
+ | |||
+ | Fixes: c742e623e941 ("mwifiex: sdio card reset enhancement") | ||
===== More patch work references ===== | ===== More patch work references ===== |