User Tools

Site Tools


en:developers:documentation:submittingpatches

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
Next revision Both sides next revision
en:developers:documentation:submittingpatches [2017/05/12 08:29]
Kalle Valo Add sectin Signed-off-by missing
en:developers:documentation:submittingpatches [2017/05/18 12:15]
Kalle Valo [Whitespace damage] Rename section Whitespace damage to Format issues
Line 28: Line 28:
 Cc: Driver maintainers,​ Other Developers</​code>​ Cc: Driver maintainers,​ Other Developers</​code>​
  
-Where [[en/​developers/​maintainers|Maintainers]] contains the list of maintainers for the piece of code you are patching. //Other Developers//​ in this case can be a list of developers who you think may like to review this patch or who changed the code you are working on recently. ​+Where [[en/​developers/​maintainers|Maintainers]] contains the list of maintainers ​and mailing lists for the piece of code you are patching. //Other Developers//​ in this case can be a list of developers ​(or mailing lists) ​who you think may like to review this patch or who changed the code you are working on recently. ​
  
 +Do note that drivers might have special requirements,​ the best is to check them from the corresponding wiki page. Here's a list for few of them:
  
 +  * [[en/​users/​drivers/​ath10k/​submittingpatches|ath10k]]
 ===== Checking state of patches from patchwork ===== ===== Checking state of patches from patchwork =====
  
Line 241: Line 243:
  
 Read [[https://​www.kernel.org/​doc/​html/​latest/​process/​submitting-patches.html#​sign-your-work-the-developer-s-certificate-of-origin|Developer'​s Certificate of Origin]] and add Signed-off-by to the commit log. Read [[https://​www.kernel.org/​doc/​html/​latest/​process/​submitting-patches.html#​sign-your-work-the-developer-s-certificate-of-origin|Developer'​s Certificate of Origin]] and add Signed-off-by to the commit log.
 +
 +==== Format issues ====
 +
 +Patch is somehow whitespace damaged, for example tabs converted to spaces, extra new lines or other modifications which prevent applying the patch without manual fixing. Or the mail is in HTML format which most of the mailing lists even block silently.
 +
 +The best way to avoid all formatting issues is to use [[https://​www.kernel.org/​pub/​software/​scm/​git/​docs/​git-send-email.html|git send-email]]
  
 ===== More patch work references ===== ===== More patch work references =====
en/developers/documentation/submittingpatches.txt ยท Last modified: 2024/05/17 14:52 by Kalle Valo